linux-kernel - Re: [PATCH] Remove BKL usage from ncpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinhD+P8y3BwNxro9fVr62MmASTubrefP9=Z8ce4@mail.gmail.com>
Date:	Mon, 27 Sep 2010 10:51:40 -0700
From:	Petr Vandrovec <petr@...drovec.name>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-fsdevel@...r.kernel.org, aia21@....ac.uk,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH] Remove BKL usage from ncpfs

On Mon, Sep 27, 2010 at 7:16 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Monday 27 September 2010, Petr Vandrovec wrote:
>> commit 92498b5267aa58e85e20c7b2cbd84d1ed86df47d
>> Author: Petr Vandrovec <petr@...drovec.name>
>> Date:   Sun Sep 26 16:19:12 2010 -0700
>>
>>     Remove BKL from ncpfs
>
> Hi Petr,
>
> Thanks for taking care of this.
>
> Would you like me to take this patch into my bkl/vfs tree? I think
> that would make it easier for me because I'm adding another instance
> of the BKL there, in the ncp_fill_super function. As far as I can tell
> that change (see below) becomes pointless with your patch.

Thanks.  I would appreciate it.

> I could either just revert my change or replace it with your patch,
> whichever you prefer.

Yes, I believe it is not necessary.  fill_super(sb) should not run
concurrently with anything else because MS_BORN and MS_ACTIVE are not
set yet so nobody else should use this sb from VFS.  One thing which
seems to be missing is doing lock_sock() around code which sets
sk->sk_{error_report,data_ready,write_space} - there does not seem to
be anything else to protect ipv4/ipv6/ipx from seeing partially
updated pointers on systems where these writes are not atomic - that's
ncpfs2.patch.

Also I found some whitespace problems, and one missing const, so if
you could merge ncpfs3.patch & ncpfs4.patch with original BKL removal,
it would be cool.  Or I can resend all 4 patches as one bigger diff if
you prefer.

Thanks,
Petr

Download attachment "ncpfs2.patch" of type "application/octet-stream" (1947 bytes)

Download attachment "ncpfs3.patch" of type "application/octet-stream" (3527 bytes)

Download attachment "ncpfs4.patch" of type "application/octet-stream" (614 bytes)