linux-kernel - Re: [PATCH] mtd : add init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=6zROsDs2zkCJOXJdiPDh53A=x7WXGZKTyHDoO@mail.gmail.com>
Date:	Mon, 27 Sep 2010 11:06:55 +0800
From:	Huang Shijie <shijie8@...il.com>
To:	dedekind1@...il.com
Cc:	David.Woodhouse@...el.com, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] mtd : add init_size hook for NAND driver

Hi Artem:
    I think the new patch is better.

The new patch will reuse the id_data.
Even if the additional id byte does not have all the information in
some case, but other infomation such as manufacture id and device id
are also useful to the NAND driver.

Best regards
Huang Shijie


2010/9/26 Artem Bityutskiy <dedekind1@...il.com>:
> On Fri, 2010-09-24 at 19:34 +0800, Huang Shijie wrote:
>> Not all the NAND devices have all the information in additional
>> id bytes.
>>
>> So add a hook in the nand_chip{} is a good method to calculate the
>> right value of oobsize, erasesize and so on.
>>
>> Without the hook,you will get the wrong value, and you have to hack
>> in the ->scan_bbt() to change the wrong value which make the code
>> mess.
>>
>> Signed-off-by: Huang Shijie <shijie8@...il.com>
>> ---
>>  drivers/mtd/nand/nand_base.c |    6 ++++--
>>  include/linux/mtd/nand.h     |    5 +++++
>>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> Taken to l2-mtd-2.6.git, thanks.
>
> --
> Best Regards,
> Artem Bityutskiy (Битюцкий Артём)
>
>

Download attachment "0001-mtd-add-init_size-hook-for-NAND-driver.patch" of type "application/octet-stream" (2723 bytes)