linux-kernel - Re: fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit() prone to misoptimization with gcc-4.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CA01D26.3030906@zytor.com>
Date:	Sun, 26 Sep 2010 21:27:18 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Volodymyr G. Lukiianyk" <volodymyrgl@...il.com>,
	Alexander Chumachenko <ledest@...il.com>,
	Glauber de Oliveira Costa <gcosta@...hat.com>
Subject: Re: fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit()
 prone to misoptimization with gcc-4.4

On 09/26/2010 10:00 AM, Linus Torvalds wrote:
> On Sun, Sep 26, 2010 at 4:53 AM, Michael Shigorin<mike@...n.org.ua>  wrote:
>>
>> The simplicity of adding that somewhat went over my head --
>> please find attached the corrected original patch against HEAD
>> with Signed-off-by: for both of us.  led@ didn't change cosmetics
>> -- thanks for providing it anyways.
>
> Ok, I think this patch is probably the right thing to do at this stage
> - and we should think about trying to see if we can improve code
> generation later.
>
> So: "Acked-by: Linus Torvalds<torvalds@...ux-foundation.org>"
>
> Ingo/Thomas/Peter - I can take this either from the x86 tree, or
> directly. Just let me know. Or do you have any alternate suggestions
> that would be appropriate?
>

(Back home now)

Yes, this patch is clearly The Right Thing.  I'll add it to the -tip 
tree and assuming no unexpected problems will send you a pull request 
tomorrow.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/