linux-kernel - Re: [PATCH] MIPS: I2C: Return -ETIMEDOUT in octeon_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100927221249.GH21564@trinity.fluff.org>
Date:	Mon, 27 Sep 2010 23:12:49 +0100
From:	Ben Dooks <ben-i2c@...ff.org>
To:	David Daney <ddaney@...iumnetworks.com>
Cc:	Bernhard Walle <walle@...science.de>, khali@...ux-fr.org,
	rade.bozic.ext@....com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: I2C: Return -ETIMEDOUT in octeon_i2c_wait() on
	timeout

On Mon, Sep 27, 2010 at 10:32:06AM -0700, David Daney wrote:
> On 09/27/2010 03:55 AM, Bernhard Walle wrote:
>> It doesn't make sense to set result to -ETIMEDOUT but return 0 (success)
>> afterwards. Since there's code in octeon_i2c_start() to handle the
>> error, it should be called.
>>
>> Signed-off-by: Bernhard Walle<walle@...science.de>
>
> Thanks for fixing this.
>
> Acked-by: David Daney <ddaney@...iumnetworks.com>

Ok, will put into my for -rc6 branch.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/