linux-kernel - Re: Request starvation with CFQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CA11F15.9020303@fusionio.com>
Date:	Tue, 28 Sep 2010 07:47:49 +0900
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	Jan Kara <jack@...e.cz>, LKML <linux-kernel@...r.kernel.org>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	Lennart Poettering <lennart@...ttering.net>
Subject: Re: Request starvation with CFQ

On 2010-09-28 07:37, Vivek Goyal wrote:
>> patches I ripped that out. The vm copes a lot better with larger depths
>> these days, so what I want to add is just a per-ioc queue limit instead.
> 
> Will you get rid of nr_requests altogether or will keep both nr_requests
> as well as per-ioc queue limits?

I was thinking that we'd keep it as a per-ioc limit.

> per-ioc queue limits will help that one io context can not monopolize the
> queue but IMHO, it does not protect against some program forking multiple
> threads and submitting bunch of IO (processes not sharing ioc).
> 
> But I guess that's a separate issue altogether. Per-ioc limit is at least
> one step forward.

So right now, if you do a driver that isn't request based, you get the
infinite queue depth already. Historically the vm didn't cope very well
with tons of dirty IO pending on the driver side, but it does a lot
better now. That said, I think we still need some sort of upper cap, but
it can be larger than what we have now and it needs to be checked
lazily. The current setup with have now with strict accounting on both
submission and completion is not a great thing for high IOPS devices.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/