linux-kernel - RE: [PATCH v3] regulators: add support max8952 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <006201cb5ee3$0100fc20$0302f460$%kim@samsung.com>
Date:	Tue, 28 Sep 2010 16:58:49 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Kukjin Kim' <kgene.kim@...sung.com>, kyungmin.park@...sung.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org
Cc:	lrg@...mlogic.co.uk, 'Changhwan Youn' <chaos.youn@...sung.com>,
	'MyungJoo Ham' <myungjoo.ham@...sung.com>,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Subject: RE: [PATCH v3] regulators: add support max8952 regulator

Kukjin Kim wrote:
> 
> Kyungmin Park wrote:
> >
> > Do you check the DVS feature?
> > It can support the DVS by GPIOs and platform can set the each voltages
at
> > each mode.
> >
> Ok...I agree about the feature's necessity that you said.
> 
> However, we don't need separate driver which has same/similar
functionality.
> So...would be better that could implement it in max8649...
> 
> Could you please do it based on this?...in fact, can't test it on SMDK.
> 
Hmm...
Kyungmin, if you have no time to do it, my team will do it.

Is it ok?

> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> > As quick review of max8649. It can't support it.
> >
> > Thank you,
> > Kyungmin Park
> >
> > -----Original Message-----
> > From: Kukjin Kim [mailto:kgene.kim@...sung.com]
> > Sent: Wednesday, September 08, 2010 8:26 AM
> > To: linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux-samsung-soc@...r.kernel.org
> > Cc: lrg@...mlogic.co.uk; Changhwan Youn; Kukjin Kim; MyungJoo Ham;
> Kyungmin
> > Park
> > Subject: [PATCH v3] regulators: add support max8952 regulator
> >
> > From: Changhwan Youn <chaos.youn@...sung.com>
> >
> > The operation of max8952 is almost similar to max8649 except the output
> > voltage range. This patch adds support the max8952 regulator using
> > current max8649 implementation. And removes separate max8952.[ch] files
> > since the functionality is now merged into this driver.
> >
> > Signed-off-by: Changhwan Youn <chaos.youn@...sung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@...sung.com>
> > Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> > ---
> > Following is as per Mark Brown's suggestion.
> > Changes since v2:
> > - Removed separate max8952.[ch] files
> >
> > Changes since v1:
> > - Added returning fail when detected wrong ID
> > - Added matching the ID from the chip in case the user got things wrong
> > - Added enum chip ID instead of 0, 1
> >
> (snip)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/