linux-kernel - Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100928082729.GA20898@elte.hu>
Date:	Tue, 28 Sep 2010 10:27:29 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org, Pekka Enberg <penberg@...nel.org>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Jean Delvare <khali@...ux-fr.org>
Subject: Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is
 undefined

* Guenter Roeck <guenter.roeck@...csson.com> wrote:

> Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> a build breakage if CONFIG_SMP is undefined. This commit
> fixes the problem.

This commit works around the problem in a hacky but not-so-ugly way.

( You might also want to include Linus's suggestion about how to fix it 
  for real in the future - so that we have at least some kind of record 
  of it. )

> Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
> Cc: Fenghua Yu <fenghua.yu@...el.com>

FYI, while i dont care about my Reported-by's but you lost a Reported-by 
tag here - you should be as careful about them as about your own 
signoffs.

> v2: Fix compile warning due to unused variable i if SMP is undefined 
> v3: include asm/smp.h instead of using ifdef CONFIG_SMP

I've started testing this fix - but i'd expect it to fix the problem - 
so consider it fixed unless i report back within a few hours that 
there's some breakage left.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/