linux-kernel - Re: [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest page table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CA1AE18.7070200@cn.fujitsu.com>
Date:	Tue, 28 Sep 2010 16:58:00 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Avi Kivity <avi@...hat.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest
 page table

On 09/27/2010 10:30 PM, Avi Kivity wrote:

>>       r = FNAME(walk_addr)(&walker, vcpu, vaddr,
>> -                 !!(access&  PFERR_WRITE_MASK),
>> -                 !!(access&  PFERR_USER_MASK),
>> -                 !!(access&  PFERR_FETCH_MASK));
>> +                 access&  PFERR_WRITE_MASK,
>> +                 access&  PFERR_USER_MASK,
>> +                 access&  PFERR_FETCH_MASK);
>>
>>       if (r) {
>>           gpa = gfn_to_gpa(walker.gfn);
> 
> Interesting.  Maybe a next step is to pass the page-fault error code
> instead of the various bits? 

Yeah, it's a good idea, i'll post a patch to do it.

> Not sure how that interacts with nested
> ept (which has a different permission model).
> 

Umm, we just move the error code parsing from the caller site to FNAME(walk_addr)
function, i think it not make trouble for implement nested ept.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/