linux-kernel - Re: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CA1C6C4.20504@mvista.com>
Date:	Tue, 28 Sep 2010 14:43:16 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Arun Murthy <arun.murthy@...ricsson.com>
CC:	lars@...afoo.de, akpm@...ux-foundation.org, kernel@...gutronix.de,
	philipp.zabel@...il.com, robert.jarzmik@...e.fr,
	marek.vasut@...il.com, eric.y.miao@...il.com, rpurdie@...ys.net,
	sameo@...ux.intel.com, kgene.kim@...sung.com,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	STEricsson_nomadik_linux@...t.st.com
Subject: Re: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data

Hello.

On 28-09-2010 14:35, Arun Murthy wrote:

> A new element 'name' is added to pwm led platform data structure.
> This is required to identify the pwm device.

> Signed-off-by: Arun Murthy<arun.murthy@...ricsson.com>
> Acked-by: Linus Walleij<linus.walleij@...ricsson.com>

[...]

> diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
> index 33a0711..7a847a0 100644
> --- a/include/linux/leds_pwm.h
> +++ b/include/linux/leds_pwm.h
> @@ -16,6 +16,7 @@ struct led_pwm {
>   struct led_pwm_platform_data {
>   	int			num_leds;
>   	struct led_pwm	*leds;
> +	char *name;
>   };

    Shouldn't '*name'be aligned, at least with '*leds'?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/