linux-kernel - Re: [PATCH 1/5] serial: Factor out uart_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100928150433.76cc8178@lxorguk.ukuu.org.uk>
Date:	Tue, 28 Sep 2010 15:04:33 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tobias Klauser <tklauser@...tanz.ch>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] serial: Factor out uart_poll_timeout() from 8250
 driver

> +/* Base timer interval for polling */
> +int uart_poll_timeout(struct uart_port *port)
> +{
> +	int timeout = port->timeout;
> +
> +	return timeout > 6 ? (timeout / 2 - 2) : 1;
> +}
> +EXPORT_SYMBOL(uart_poll_timeout);

inline this rather than exporting it and making it global - it's a tiny
spec of code and the export symbol probably costs more !
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/