| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Sep 2010 21:08:08 +0400 From: Vasiliy Kulikov <segooon@...il.com> To: kernel-janitors@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...e.de>, Denis Kirjanov <dkirjanov@...nel.org>, Kulikov Vasiliy <segooon@...il.com>, "David S. Miller" <davem@...emloft.net>, Jiri Pirko <jpirko@...hat.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead of kfree() Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) @@ struct net_device* dev; @@ -kfree(dev) +free_netdev(dev) Signed-off-by: Vasiliy Kulikov <segooon@...il.com> --- Compile tested. drivers/staging/slicoss/slicoss.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 58ff123..18f1103 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev) slic_global.num_slic_cards--; slic_card_cleanup(card); } - kfree(dev); + free_netdev(dev); pci_release_regions(pcidev); } -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists