linux-kernel - Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100928175808.GG10739@opensource.wolfsonmicro.com>
Date:	Tue, 28 Sep 2010 10:58:09 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Masayuki Ohtak <masa-korg@....okisemi.com>
Cc:	meego-dev@...go.com, Andrew Morton <akpm@...ux-foundation.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Alek Du <alek.du@...el.com>,
	Richard Röjfors 
	<richard.rojfors@...ean-labs.com>,
	Mike Frysinger <vapier@...too.org>,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	andrew.chih.howe.khor@...el.com, kok.howg.ewe@...el.com,
	joel.clark@...el.com, yong.y.wang@...el.com,
	Tomoya MORINAGA <morinaga526@....okisemi.com>,
	margie.foster@...el.com
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_GPIO driver to
 2.6.35

On Tue, Sep 28, 2010 at 06:37:57PM +0900, Masayuki Ohtak wrote:

> +	gpio->base = (u32)chip->pch_gpio_base_address;

> +	chip->reg = chip->pch_gpio_base_address;

The GPIO base passed to gpiolib should be the base GPIO number for the
device, not the address of the control registers.  Normally this would
be passed in via platform data or set to -1 to allow the core to assign
a slot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/