lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Sep 2010 19:06:11 -0700 From: "Nicholas A. Bellinger" <nab@...ux-iscsi.org> To: linux-scsi <linux-scsi@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, Vasu Dev <vasu.dev@...ux.intel.com>, Tim Chen <tim.c.chen@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>, Matthew Wilcox <willy@...ux.intel.com>, James Bottomley <James.Bottomley@...e.de>, Mike Christie <michaelc@...wisc.edu>, Jens Axboe <jaxboe@...ionio.com> Cc: James Smart <james.smart@...lex.com>, Andrew Vasquez <andrew.vasquez@...gic.com>, FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, Hannes Reinecke <hare@...e.de>, Joe Eykholt <jeykholt@...co.com>, Christoph Hellwig <hch@....de>, Jon Hawley <warthog9@...nel.org>, MPTFusionLinux <DL-MPTFusionLinux@....com>, "eata.c maintainer" <dario.ballabio@...ind.it>, Luben Tuikov <ltuikov@...oo.com>, mvsas maintainer <kewei@...vell.com>, pm8001 maintainer Jack Wang <jack_wang@...sh.com>, Nicholas Bellinger <nab@...ux-iscsi.org> Subject: [RFC v4 07/19] libfc: Remove host_lock unlock() + lock() from fc_queuecommand() From: Nicholas Bellinger <nab@...ux-iscsi.org> This patch removes the now legacy host_lock unlock() + lock() optimization fc_fcp.c:fc_queuecommand() Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org> --- drivers/scsi/libfc/fc_fcp.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c797f6b..140cd94 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -1751,8 +1751,7 @@ static inline int fc_fcp_lport_queue_ready(struct fc_lport *lport) * @cmd: The scsi_cmnd to be executed * @done: The callback function to be called when the scsi_cmnd is complete * - * This is the i/o strategy routine, called by the SCSI layer. This routine - * is called with the host_lock held. + * This is the i/o strategy routine, called by the SCSI layer. */ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) { @@ -1772,7 +1771,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) done(sc_cmd); return 0; } - spin_unlock_irq(lport->host->host_lock); if (!*(struct fc_remote_port **)rport->dd_data) { /* @@ -1849,7 +1847,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) rc = SCSI_MLQUEUE_HOST_BUSY; } out: - spin_lock_irq(lport->host->host_lock); return rc; } EXPORT_SYMBOL(fc_queuecommand); -- 1.7.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists