linux-kernel - Re: {painfully BISECTED} Please revert f25c80a4b2: arch/um/drivers: remove duplicate structure field initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinyPHP2wQvCiZnN3QkX96LM_25GiLpn0by6jfXo@mail.gmail.com>
Date:	Tue, 28 Sep 2010 14:08:35 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, bharrosh@...asas.com, julia@...u.dk,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, shemminger@...tta.com
Subject: Re: {painfully BISECTED} Please revert f25c80a4b2: arch/um/drivers:
 remove duplicate structure field initialization

On Tue, Sep 28, 2010 at 2:00 PM, David Miller <davem@...emloft.net> wrote:
> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Date: Tue, 28 Sep 2010 13:57:04 -0700
>
>> So perhaps something like the attached patch would make it work, and
>> have the locking in place that apparently people think it should have?
>
> I'm fine with this if it works:
>
> Acked-by: David S. Miller <davem@...emloft.net>

And you can add my sign-off to it if somebody tests it.

It does look like the obvious fix. The "wrapper" is simply totally
wrong as-is, and passes the wrong thing entirely to eth_mac_addr()
afaik.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/