[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikOUV+-WX7eek7ocwQLDxTcWSYJ4kga6ctTi9MG@mail.gmail.com>
Date: Wed, 29 Sep 2010 15:56:42 +0800
From: huang ying <huang.ying.caritas@...il.com>
To: Robert Richter <robert.richter@....com>
Cc: Huang Ying <ying.huang@...el.com>, Don Zickus <dzickus@...hat.com>,
Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH -v2 3/7] x86, NMI, Rename memory parity error to PCI SERR error
On Tue, Sep 28, 2010 at 10:29 PM, Robert Richter <robert.richter@....com> wrote:
> On 27.09.10 21:33:37, Huang Ying wrote:
>
>> I suggest to
>> print the reason byte only if (!(reason & 0xc0) && reason), where the
>> reason is really unknown.
>
> Why make it this complex for an error message?
It's just a "else" branch for original "if (reason & 0xc0)" code, so
it is not too complex.
Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists