linux-kernel - Re: [RFC v4 14/19] buslogic: Remove host_lock unlock() + lock() from BusLogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Sep 2010 00:55:12 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	linux-scsi <linux-scsi@...r.kernel.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Vasu Dev <vasu.dev@...ux.intel.com>,
	Tim Chen <tim.c.chen@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	James Bottomley <James.Bottomley@...e.de>,
	Mike Christie <michaelc@...wisc.edu>,
	Jens Axboe <jaxboe@...ionio.com>,
	James Smart <james.smart@...lex.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Hannes Reinecke <hare@...e.de>,
	Joe Eykholt <jeykholt@...co.com>,
	Christoph Hellwig <hch@....de>,
	Jon Hawley <warthog9@...nel.org>,
	MPTFusionLinux <DL-MPTFusionLinux@....com>,
	"eata.c maintainer" <dario.ballabio@...ind.it>,
	Luben Tuikov <ltuikov@...oo.com>,
	mvsas maintainer <kewei@...vell.com>,
	pm8001 maintainer Jack Wang <jack_wang@...sh.com>
Subject: Re: [RFC v4 14/19] buslogic: Remove host_lock unlock() + lock()
	from BusLogic_QueueCommand()

On Mon, 2010-09-27 at 19:07 -0700, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
> 
> This patch removes the now legacy host_lock unlock() + lock() optimization
> from buslogic.c:BusLogic_QueueCommand()
> 

FYI Guys, I have gone ahead and dropped this patch for RFCv5 as the
BusLogic LLD was the only patch in the v4 series who did not set
SHT->unlocked_qcmds=1, so we will still need the BusLogic_QueueCommand()
unlock -> lock before calling BusLogic_Delay() for the two cases below.

Thanks,

--nab

> Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
> ---
>  drivers/scsi/BusLogic.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index fc0b4b8..f39b4fc 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2837,9 +2837,7 @@ static int BusLogic_QueueCommand(struct scsi_cmnd *Command, void (*CompletionRou
>  	 */
>  	CCB = BusLogic_AllocateCCB(HostAdapter);
>  	if (CCB == NULL) {
> -		spin_unlock_irq(HostAdapter->SCSI_Host->host_lock);
>  		BusLogic_Delay(1);
> -		spin_lock_irq(HostAdapter->SCSI_Host->host_lock);
>  		CCB = BusLogic_AllocateCCB(HostAdapter);
>  		if (CCB == NULL) {
>  			Command->result = DID_ERROR << 16;
> @@ -2965,10 +2963,8 @@ static int BusLogic_QueueCommand(struct scsi_cmnd *Command, void (*CompletionRou
>  		   error as a Host Adapter Hard Reset should be initiated soon.
>  		 */
>  		if (!BusLogic_WriteOutgoingMailbox(HostAdapter, BusLogic_MailboxStartCommand, CCB)) {
> -			spin_unlock_irq(HostAdapter->SCSI_Host->host_lock);
>  			BusLogic_Warning("Unable to write Outgoing Mailbox - " "Pausing for 1 second\n", HostAdapter);
>  			BusLogic_Delay(1);
> -			spin_lock_irq(HostAdapter->SCSI_Host->host_lock);
>  			if (!BusLogic_WriteOutgoingMailbox(HostAdapter, BusLogic_MailboxStartCommand, CCB)) {
>  				BusLogic_Warning("Still unable to write Outgoing Mailbox - " "Host Adapter Dead?\n", HostAdapter);
>  				BusLogic_DeallocateCCB(CCB);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/