linux-kernel - Re: {painfully BISECTED} Please revert f25c80a4b2: arch/um/drivers: remove duplicate structure field initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CA2FBBB.3040004@panasas.com>
Date:	Wed, 29 Sep 2010 10:41:31 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Julia Lawall <julia@...u.dk>,
	"David S. Miller" <davem@...emloft.net>,
	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: {painfully BISECTED} Please revert f25c80a4b2: arch/um/drivers:
 remove duplicate structure field initialization

On 09/28/2010 10:57 PM, Linus Torvalds wrote:
> On Tue, Sep 28, 2010 at 1:47 PM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
>>
>> And I misread that, assuming that it's just a wrapper around
>> eth_mac_addr().  Only it isn't, because it passes eth_mac_addr() the
>> MAC address's address directly (with ->sa_data).  But eth_mac_addr()
>> expects a `struct sockaddr *'.
>>
>> And for some wtf reason, eth_mac_addr() passes that `struct
>> sockaddr *' in a `void *', thus cunningly hiding the bug.
>>
>> Yeah, please revert it.
> 
> Well, the alternative would be to just fix uml_net_set_mac(). The code
> before the patch was clearly crap too, so reverting may make it work,
> but gets us back to a stupid situation with two different initializers
> for one field.
> 
> So perhaps something like the attached patch would make it work, and
> have the locking in place that apparently people think it should have?
> 
> Boaz?
> 

OK I get the picture. We should attempt a proper fixing. Well since
I get to test it, then I get to fix it as well, right ;-)?

With this I'm now back to my usual: boots fine but half of the times
not halting. But I think that's a Fedora12 problem with interaction
with uml. (Which I do not have time to investigate)

>                      Linus

Thanks, have a good day
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/