linux-kernel - Re: [PATCH] RDMA/cxgb4: Add default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Sep 2010 12:21:14 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Steve Wise <swise@...ngridcomputing.com>,
	linux-rdma@...r.kernel.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files.

 > The main difference between default_llseek and generic_file_llseek
 > is that default_llseek doesn't care about the maximum file size
 > of the underlying file system, which is ULONG_MAX on debugfs,
 > so they are equivalent.

I thought default_llseek also takes the BKL still?

 > In general, the preferred one is no_llseek for those files where
 > you know you do not need to seek. If you do, I'd use default_llseek
 > for character devices and generic_file_llseek for file systems
 > that set the s_maxbytes.

The case in question is for debugfs files, so we should use
generic_file_llseek, right?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/