linux-kernel - Re: [PATCH v2 15/22] Staging: rtl8192u: Makefile: cleaned up makefile cflag lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100930061926.GB8707@kroah.com>
Date:	Wed, 29 Sep 2010 23:19:26 -0700
From:	Greg KH <greg@...ah.com>
To:	walter harms <wharms@....de>
Cc:	Tracey Dent <tdent48227@...il.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 15/22] Staging: rtl8192u: Makefile: cleaned up
	makefile cflag lines

On Sat, Sep 25, 2010 at 12:52:44PM +0200, walter harms wrote:
> 
> 
> Tracey Dent schrieb:
> > Changed to use proper ccflags-y option
> > 
> > Signed-off-by: Tracey Dent <tdent48227@...il.com>
> > ---
> >  drivers/staging/rtl8192u/Makefile |   20 ++++++++++----------
> >  1 files changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile
> > index 738f4a8..1710921 100644
> > --- a/drivers/staging/rtl8192u/Makefile
> > +++ b/drivers/staging/rtl8192u/Makefile
> > @@ -1,16 +1,16 @@
> >  NIC_SELECT = RTL8192U
> >  
> > -EXTRA_CFLAGS += -std=gnu89
> > -EXTRA_CFLAGS += -O2
> > +ccflags-y := -std=gnu89
> > +ccflags-y := -O2
> >  
> 
> Is this -O2 a requirement ? I did not look into other makefiles but i would expect
> -O2 to be set in the main-makefile. (Imagine someone disables the optimsation only
> to find a driver that does behave different).

Yes, it should be removed, but that's not the goal of this patch.

> > -EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y
> > -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> > -EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
> 
> Is THOMAS_BEACON etc a defined algorithem or so ? If not a bit more desciptive name
> would be nice

Lots of things would be "nice" for this driver :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/