linux-kernel - Re: [PATCH 3/4] cs5535: add some additional cs5535-specific GPIO functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100930010501.GA28145@kroah.com>
Date:	Wed, 29 Sep 2010 18:05:01 -0700
From:	Greg KH <greg@...ah.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Greg KH <gregkh@...e.de>, devel@...verdev.osuosl.org,
	dsd@...top.org, jon.nettleton@...il.com,
	linux-geode@...ts.infradead.org, linux-kernel@...r.kernel.org,
	cjb@...top.org
Subject: Re: [PATCH 3/4] cs5535: add some additional cs5535-specific GPIO
	functionality

On Sat, Sep 25, 2010 at 07:07:12PM -0700, Andres Salomon wrote:
> 
> This adds (well, re-adds actually) handling for events/IRQs through cs5535
> GPIOs.  In the wild and wooly world of CS5535, setup_event() is for
> assigning an IRQ to a GPIO filter/event pair, and set_irq() sets up
> the pair to trigger IRQs.
> 
> These should really only be used in highly platform-specific drivers (such
> as OLPC's DCON driver).  Sadly, because set_irq() uses MSRs, this causes the
> driver to become X86-specific.
> 
> Signed-off-by: Andres Salomon <dilinger@...ued.net>
> ---
>  drivers/gpio/Kconfig       |    2 +-
>  drivers/gpio/cs5535-gpio.c |   52 ++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/cs5535.h     |    2 +

I can't take this change without the gpio subsystem maintainer acking
it.  Can you get that approval from them?

I'm guessing that your 4/4 patch here depends on it, right?  If so, I'll
hold off on applying that patch until we can figure out how to handle
this, ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/