linux-kernel - Re: [PATCH] DMI to disable Vista compatibility on MSI GX723 Notebook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Sep 2010 14:25:52 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	"Lee, Chun-Yi" <joeyli.kernel@...il.com>
Cc:	lenb@...nel.org, rui.zhang@...el.com, melchior+kernel@....edu,
	jerone.young@...onical.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, patrol@...us.cz,
	"Lee, Chun-Yi" <jlee@...ell.com>
Subject: Re: [PATCH] DMI to disable Vista compatibility on MSI GX723
	Notebook

On Thu, Sep 30, 2010 at 06:44:11PM +0800, Lee, Chun-Yi wrote:
> The brightness control hotkey don't work with Vista compatibility
> , because MSI GX723 included a infinite while loop in DSDT when
> brightness control hotkey pressed.
> MSI GX723 used Nvida video card, the infinite while loop must be a
> workaround with Nvidia's Vista driver.

While this would work, it seems likely that the expected behaviour is 
for the graphics driver to call the NVIF method. We don't do that as 
yet, but when we do I'm worried about it potentially resulting in this 
system being in an unexpected state (NVIF is used, but we don't claim to 
be Vista). Can you add a comment indicating that it should be reverted 
once nouveau grows support?

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/