linux-kernel - Re: [PATCH] drivers:staging:ti-st: mv ti_wilink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100930115123.GB2779@kroah.com>
Date:	Thu, 30 Sep 2010 04:51:23 -0700
From:	Greg KH <greg@...ah.com>
To:	pavan_savoy@...com
Cc:	gregkh@...e.de, alan@...rguk.ukuu.org.uk,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:ti-st: mv ti_wilink_st header

On Wed, Sep 29, 2010 at 12:25:22PM -0400, pavan_savoy@...com wrote:
> From: Pavan Savoy <pavan_savoy@...com>
> 
> Greg,
> 
> How is the movement of drivers done out of staging?
> Should I submit patches like these, which move individual files without
> breaking the build during anytime of movement?

Yes.

> In few following days I plan to submit patches to move the ST headers sources
> out.
> ti_wilink_st.h -> include/linux/
> st_core.c, st_kim.c and st_ll.c -> drivers/misc/
> Makefile and Kconfig changes to drivers/misc/Kconfig and drivers/misc/Makefile
> bt_drv.c -> drivers/bluetooth/

Yes, that sounds great.

But, the bluetooth patch should go to the bluetooth maintainer for his
review, I'll need the ack from him before I can apply it.

Oh, this patch looks nice, but I found one problem:

> --- a/drivers/staging/ti-st/ti_wilink_st.h
> +++ /dev/null
> -#ifndef TI_WILINK_ST_H
> -#define TI_WILINK_ST_H
> -
> -/* TODO:
> - * Move the following to tty.h upon acceptance
> - */
> -#define N_TI_WL	22	/* Ldisc for TI's WL BT, FM, GPS combo chips */

We need to do that now, before you move this file.

Then, you can drop this:

> -#ifdef __KERNEL__

As it will not be needed, right?

Care to send me a patch that does this first?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/