linux-kernel - Re: timer: permit statically-declared work with deferrable timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1009302207060.2416@localhost6.localdomain6>
Date:	Thu, 30 Sep 2010 22:08:15 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Phil Carmody <ext-phil.2.carmody@...ia.com>
cc:	arjan@...ux.intel.com, akpm@...ux-foundation.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org, Artem.Bityutskiy@...ia.com
Subject: Re: timer: permit statically-declared work with deferrable timers

On Thu, 30 Sep 2010, Phil Carmody wrote:

> 
> Arjen, Thomas,
> 
> This patch is an enabler which hopefully can lead to simplification of code 
> elsewhere. For example, it would turn Artem's patch I refer to in the commit
> message (8eab945c5616fc984e97b922d6a2559be93f39a1) into just:
> 
> -static DECLARE_DELAYED_WORK(cache_cleaner, do_cache_clean);
> +static DECLARE_DEFERRED_WORK(cache_cleaner, do_cache_clean);
> 
> rather than the creation of a __init helper that required touching 3 files.
> 
> I'm prepared to follow up with such simplifying patches if it's considered
> worthwhile.

If it simplies stuff, no objections from my side. The patch looks
reasonable enough.

How many (ab)users will it clean up ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/