linux-kernel - Re: [PATCH] de2104x: disable media debug messages by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100929.194756.02282581.davem@davemloft.net>
Date:	Wed, 29 Sep 2010 19:47:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jgarzik@...ox.com
Cc:	linux@...nbow-software.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] de2104x: disable media debug messages by default

From: Jeff Garzik <jgarzik@...ox.com>
Date: Tue, 28 Sep 2010 14:51:45 -0400

> On 09/28/2010 02:18 PM, Ondrej Zary wrote:
>> Print media debug messages only when HW debug is enabled.
>>
>> Signed-off-by: Ondrej Zary<linux@...nbow-software.org>
>>
>> --- linux-2.6.36-rc3-/drivers/net/tulip/de2104x.c 2010-09-28
>> --- 19:50:51.000000000 +0200
>> +++ linux-2.6.36-rc3/drivers/net/tulip/de2104x.c 2010-09-28
>> 20:05:34.000000000 +0200
>> @@ -948,8 +948,9 @@ static void de_set_media (struct de_priv
>>   	else
>>   		macmode&= ~FullDuplex;
>>
>> -	if (netif_msg_link(de)) {
>> +	if (netif_msg_link(de))
>>   		dev_info(&de->dev->dev, "set link %s\n", media_name[media]);
>> +	if (netif_msg_hw(de)) {
>>   		dev_info(&de->dev->dev, "mode 0x%x, sia 0x%x,0x%x,0x%x,0x%x\n",
>>   			 dr32(MacMode), dr32(SIAStatus),
>>   			 dr32(CSR13), dr32(CSR14), dr32(CSR15));
> 
> Acked-by: Jeff Garzik <jgarzik@...hat.com>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/