linux-kernel - Re: [PATCH v2] isofs: Fix lseek() to position beyond 4 GB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100930222625.GH3573@quack.suse.cz>
Date:	Fri, 1 Oct 2010 00:26:25 +0200
From:	Jan Kara <jack@...e.cz>
To:	Jan Andres <jandres@....net>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] isofs: Fix lseek() to position beyond 4 GB

On Fri 01-10-10 00:14:30, Jan Kara wrote:
> On Wed 04-08-10 22:52:46, Jan Andres wrote:
> > isofs supports files larger than 4 GB by using multi-extent files.
> > However an lseek() to a position beyond 4 GB in such a file will
> > fail with EINVAL, because s_maxbytes in the isofs superblock is
> > initialized to 2^32-1, and generic_file_llseek() checks against
> > that value.
> > 
> > I therefore suggest increasing the value of s_maxbytes to have
> > full support for large files in isofs. With multi-extent files, file
> > size is only limited by the maximum size of the file system (8 TB),
> > so this seems a reasonable value for s_maxbytes.
>   OK, I had a look into the relevant code and it seems that the isofs
> code should properly handle files upto 4TB and with a small fix (attached)
> upto 8TB as you claim. So I'll take your patch and merge it with Linus.
  Oops, I now noticed that Al has already merged your patch. OK, so I'll
just merge my fix separately.

 								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/