linux-kernel - Re: [PATCH] Fix capi devicenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1285922192.13411.53.camel@marc>
Date:	Fri, 01 Oct 2010 10:36:32 +0200
From:	"Marc - A. Dahlhaus" <mad@....de>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	isdn@...ux-pingi.de
Subject: Re: [PATCH] Fix capi devicenames

Am Donnerstag, den 30.09.2010, 21:20 +0200 schrieb Kay Sievers:
--8<--
> 
> devices.txt is just bogus in this case and states stuff which was
> never used in the real world. But you don't need to touch it. Just add
> the naming hints (char *(*devnode)) to the capi class and nothing will
> change, the device names in /sys and everywhere else will stay as they
> are today, just devtmpfs and udev will create the right device nodes
> out of the kernel supplied additional information. We did this for the
> rest of the kernel the same way.

Hello Kay,

for the capi tty, if not mistaken, it looks like i need to add a
dev->devnode = 'capi/';
line but i have no clue what it needs to change the capi_class.
Looks like a larger rework of the code in capi.c to me.

It would collide in the kernel if i fix the typo for the control device
but don't change the tty device name by the same time.
(20th capi application tty would become capi20 under sysfs)

So i took the approach to ignore the devices.txt in the v2 patch and
just fix the control device node to conform to the spec and also fix the
tty node names to the ones of capifs that superseded the manualy created
tty device nodes mentioned in devices.txt

Hope this is more appropriate than my first patch.

Is there a documentation that could guide me in how to fix it in the way
you suggested, if the v2 patch also gets naked?

thanks,

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/