linux-kernel - Re: [PATCH] DMI to disable Vista compatibility on MSI GX723 Notebook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4CA62CF0020000230002124F@novprvlin0050.provo.novell.com>
Date:	Fri, 01 Oct 2010 02:48:16 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<mjg59@...f.ucam.org>
Cc:	<jerone.young@...onical.com>, <melchior+kernel@....edu>,
	<rui.zhang@...el.com>, <lenb@...nel.org>, <patrol@...us.cz>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] DMI to disable Vista compatibility on MSI GX723
 Notebook

Hi Matthew, 

Thank's for your review!

於 四，2010-09-30 於 14:25 +0100，Matthew Garrett 提到：
> On Thu, Sep 30, 2010 at 06:44:11PM +0800, Lee, Chun-Yi wrote:
> > The brightness control hotkey don't work with Vista compatibility
> > , because MSI GX723 included a infinite while loop in DSDT when
> > brightness control hotkey pressed.
> > MSI GX723 used Nvida video card, the infinite while loop must be a
> > workaround with Nvidia's Vista driver.
> 
> While this would work, it seems likely that the expected behaviour is 
> for the graphics driver to call the NVIF method. We don't do that as 
> yet, but when we do I'm worried about it potentially resulting in this 
> system being in an unexpected state (NVIF is used, but we don't claim to 
> be Vista). Can you add a comment indicating that it should be reverted 
> once nouveau grows support?
> 

I added comment to source code to remind need remove the MSI GX723 from
blacklist table after nouveau driver support NVIF method.

The attached file is new patch. Do I need send the patch to kernel mail
loop by git send-mail again?


Thank's
Joey Lee


View attachment "0001-DMI-to-disable-Vista-compatibility-on-MSI-GX723-Note.PATCH" of type "text/plain" (1713 bytes)