linux-kernel - Re: [PATCH 1/3] MFD: allow for bypass of cell resource conflict check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101001100619.GA3064@sortiz-mobl>
Date:	Fri, 1 Oct 2010 12:06:20 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Daniel Drake <dsd@...top.org>
Cc:	linux-kernel@...r.kernel.org, laforge@...monks.org
Subject: Re: [PATCH 1/3] MFD: allow for bypass of cell resource conflict
 check

Hi Daniel,

On Thu, Sep 30, 2010 at 09:55:36PM +0100, Daniel Drake wrote:
> The upcoming VIA VX855 MFD driver needs to communicate resources
> to subdevices where the resources may be claimed by ACPI.
> 
> Add a flag to mfd_cell to request that resources are not policed.
Thanks a lot. All 3 patches applied.

Cheers,
Samuel.


> Signed-off-by: Daniel Drake <dsd@...top.org>
> ---
>  drivers/mfd/mfd-core.c   |    8 +++++---
>  include/linux/mfd/core.h |    3 +++
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 1823a57..d1c8605 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -65,9 +65,11 @@ static int mfd_add_device(struct device *parent, int id,
>  			res[r].end   = cell->resources[r].end;
>  		}
>  
> -		ret = acpi_check_resource_conflict(res);
> -		if (ret)
> -			goto fail_res;
> +		if (!cell->ignore_resource_conflicts) {
> +			ret = acpi_check_resource_conflict(res);
> +			if (ret)
> +				goto fail_res;
> +		}
>  	}
>  
>  	ret = platform_device_add_resources(pdev, res, cell->num_resources);
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 11d740b..cb93d80 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -44,6 +44,9 @@ struct mfd_cell {
>  	 */
>  	int			num_resources;
>  	const struct resource	*resources;
> +
> +	/* don't check for resource conflicts */
> +	bool			ignore_resource_conflicts;
>  };
>  
>  extern int mfd_add_devices(struct device *parent, int id,
> -- 
> 1.7.2.3
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/