linux-kernel - Re: gas 2.16 and assembly macros -- entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100930180100.4607034f.akpm@linux-foundation.org>
Date:	Thu, 30 Sep 2010 18:01:00 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Jan Beulich <JBeulich@...ell.com>, Ingo Molnar <mingo@...e.hu>,
	heukelum@...tmail.fm, tglx@...utronix.de,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: gas 2.16 and assembly macros -- entry_64.S build failure

On Thu, 30 Sep 2010 17:26:13 -0700 "H. Peter Anvin" <hpa@...or.com> wrote:

> On 09/16/2010 04:21 AM, Jan Beulich wrote:
> >>
> >> Yes, to only generate CFI on binutils that allows us to write sane 
> >> looking code.
> >>
> >> I.e. to disable CONFIG_AS_CFI on binutils that are broken for this.
> > 
> > Again - that won't help, as it's the macro invocation that gas
> > fails one, not one of the actual .cfi_* directives.
> > 
> 
> Looking again at this issue with the binutils version from hell
> (sigh)... I'm running quickly out of ideas.
> 
> The problem is that cpp inserts spaces around expansions, so:
> 
> 	pushq_cfi $(USER_DS)
> 
> ... turns into something like ...
> 
> 	pushq_cfi $( ( 5 * 8 + 3 ) )
> 
> ... which these old versions of gas considers multiple arguments to the
> macro, even though there is no comma anywhere.

Could we run another little program after cpp which takes the spaces
out again?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/