linux-kernel - Re: [PATCH][RESEND] nommu: add anonymous page memcg accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <WC20101001143139.810346@digidescorp.com>
Date:	Fri, 01 Oct 2010 09:31:39 -0500
From:	"Steve Magnani" <steve@...idescorp.com>
To:	"David Howells" <dhowells@...hat.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH][RESEND] nommu: add anonymous page memcg accounting

David Howells <dhowells@...hat.com> wrote:
> 
> Do we really need to do memcg accounting in NOMMU mode?  Might it be
> better to just apply the attached patch instead?
> 
> David
> ---
> diff --git a/init/Kconfig b/init/Kconfig
> index 2de5b1c..aecff10 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -555,7 +555,7 @@ config RESOURCE_COUNTERS
>  
>  config CGROUP_MEM_RES_CTLR
>  	bool "Memory Resource Controller for Control Groups"
> -	depends on CGROUPS && RESOURCE_COUNTERS
> +	depends on CGROUPS && RESOURCE_COUNTERS && MMU
>  	select MM_OWNER
>  	help
>  	  Provides a memory resource controller that manages both anonymous

If anything I think nommu is one of the better applications of memcg. Since nommu typically == 
embedded, being able to put potential memory pigs in a sandbox so they can't destabilize the 
system is a Good Thing. That was my motivation for doing this in the first place and it works 
quite well.

If it would be better to make nommu memcg contingent on some new Kconfig option, we can do 
that. 

Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/