linux-kernel - Re: [PATCH] regulator: max8649

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101001173643.GB21157@opensource.wolfsonmicro.com>
Date:	Fri, 1 Oct 2010 10:36:44 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH] regulator: max8649 - fix setting extclk_freq

On Fri, Oct 01, 2010 at 07:18:14PM +0800, Axel Lin wrote:
> 2010/10/1 Mark Brown <broonie@...nsource.wolfsonmicro.com>:

> > Are there existing users of the driver?  It's not always 100% clear if
> > people are expecting bitfield values that will be shifted in or values
> > that can be ored directly in.  I don't really mind either way but I'd
> > rather be careful.

> I think I should explain this way:

> In max8649.h , we have
> enum {
>         MAX8649_EXTCLK_26MHZ = 0,
>         MAX8649_EXTCLK_13MHZ,
>         MAX8649_EXTCLK_19MHZ,   /* 19.2MHz */
> };

OK, that's clearer.  When changing the interpretation of existing
platform data like this it's good to note this sort of thing in the
changelog since merge issues can be a real pain.

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/