[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101001185250.GK14064@sgi.com>
Date: Fri, 1 Oct 2010 13:52:50 -0500
From: Robin Holt <holt@....com>
To: Nathan Fontenot <nfont@...tin.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
linuxppc-dev@...ts.ozlabs.org, Greg KH <greg@...ah.com>,
Dave Hansen <dave@...ux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
Robin Holt <holt@....com>, steiner@....com
Subject: Re: [PATCH 4/9] v3 Allow memory blocks to span multiple memory
sections
On Fri, Oct 01, 2010 at 01:31:51PM -0500, Nathan Fontenot wrote:
> Update the memory sysfs code such that each sysfs memory directory is now
> considered a memory block that can span multiple memory sections per
> memory block. The default size of each memory block is SECTION_SIZE_BITS
> to maintain the current behavior of having a single memory section per
> memory block (i.e. one sysfs directory per memory section).
>
> For architectures that want to have memory blocks span multiple
> memory sections they need only define their own memory_block_size_bytes()
> routine.
>
> Signed-off-by: Nathan Fontenot <nfont@...tin.ibm.com>
>
> ---
> drivers/base/memory.c | 155 ++++++++++++++++++++++++++++++++++----------------
> 1 file changed, 108 insertions(+), 47 deletions(-)
>
> Index: linux-next/drivers/base/memory.c
> ===================================================================
> --- linux-next.orig/drivers/base/memory.c 2010-09-30 14:13:50.000000000 -0500
> +++ linux-next/drivers/base/memory.c 2010-09-30 14:46:00.000000000 -0500
...
> +static unsigned long get_memory_block_size(void)
> +{
> + u32 block_sz;
^^^
I think this should be unsigned long. u32 will work, but everything
else has been changed to use unsigned long. If you disagree, I will
happily acquiesce as nothing is currently broken. If SGI decides to make
memory_block_size_bytes more dynamic, we will fix this up at that time.
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists