linux-kernel - Re: [PATCH] serial: ioc3_serial: release resources in error return path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinGZEc7V1MH=xyhdKy5=Pg1NRC9xjVEuqBSWNFL@mail.gmail.com>
Date:	Fri, 1 Oct 2010 13:47:52 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	Rahul Ruikar <rahul.ruikar@...il.com>
Cc:	Pat Gefre <pfg@....com>, Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, linux-mips@...ux-mips.org,
	linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: ioc3_serial: release resources in error return path

On Tue, Sep 28, 2010 at 9:41 PM, Rahul Ruikar <rahul.ruikar@...il.com> wrote:
> -                       goto out4;
> +                       goto out3;

> -               goto out4;
> +               goto out3;

you changed *all* uses of out4 to out3, so with this patch I see:

drivers/serial/ioc3_serial.c:2152: warning: label ‘out4’ defined but not used

So I dropped the first hunks, and changed the last one to this:

>   out4:
> +       for (cnt = 0; cnt < phys_port; cnt++)
> +               kfree(ports[cnt]);
> +
>        kfree(card_ptr);
>        return ret;

Applied with this change.

Thanks

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/