linux-kernel - Re: [PATCH 01/23] Hibernation: Split compression support out.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Oct 2010 23:28:09 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Nigel Cunningham <nigel@...onice.net>
Cc:	Linux PM <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"TuxOnIce-devel" <tuxonice-devel@...onice.net>
Subject: Re: [PATCH 01/23] Hibernation: Split compression support out.

On Monday, September 27, 2010, Nigel Cunningham wrote:
> Hi.
> 
> On 28/09/10 06:27, Rafael J. Wysocki wrote:
> > On Monday, September 27, 2010, Nigel Cunningham wrote:
...
> > This one doesn't really good to me.  What I'd prefer would be to have a
> > structure of "swap operations" pointers like ->start(), ->write_data(),
> > ->read_data(), and ->finish() that will point to the functions in this file
> > (if compression is to be used) or to the "old" swap_write_page()/swap_read_page()
> > otherwise.  That would reduce the number of the
> > (flags&  SF_NOCOMPRESS_MODE) checks quite substantially and will likely result
> > in code that's easier to follow.
> 
> Me too. I was heading in that direction, but not doing it in one step. 
> I'll happily change that.

I'm still waiting for the reworked patch.  If you can submit it in a few days
and it looks good, I'll include it into the pull request for 2.6.37.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/