linux-kernel - Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Oct 2010 16:01:33 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Masayuki Ohtak <masa-korg@....okisemi.com>
Cc:	meego-dev@...go.com, Andrew Morton <akpm@...ux-foundation.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Alek Du <alek.du@...el.com>,
	Richard Röjfors 
	<richard.rojfors@...ean-labs.com>,
	Mike Frysinger <vapier@...too.org>,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	andrew.chih.howe.khor@...el.com, kok.howg.ewe@...el.com,
	joel.clark@...el.com, yong.y.wang@...el.com,
	Tomoya MORINAGA <morinaga526@....okisemi.com>,
	margie.foster@...el.com
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_GPIO driver to
 2.6.35

On Wed, Sep 29, 2010 at 10:20:38AM +0900, Masayuki Ohtak wrote:

> +static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
> +				     int val)
> +{
> +	struct pch_gpio *chip =	container_of(gpio, struct pch_gpio, gpio);
> +	u32 pm;
> +
> +	mutex_lock(&chip->lock);
> +	pm = ioread32(&chip->reg->pm) & PCH_GPIO_ALL_PINS;
> +	pm |= (1 << nr);
> +	iowrite32(pm, &chip->reg->pm);
> +	mutex_unlock(&chip->lock);
> +
> +	return 0;
> +}

This doesn't do anything with val - it should be doing the equivalent of
a gpio_set() to set the initial value of the GPIO when switching it to
output mode.

Otherwise this looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/