linux-kernel - Re: [PATCH] PM / Runtime: Reduce code duplication in core helper functions (was: Re: [linux-pm] [PATCH] PM: add synchronous ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1010021012590.15874-100000@netrider.rowland.org>
Date:	Sat, 2 Oct 2010 10:15:26 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	linux-pm@...ts.linux-foundation.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / Runtime: Reduce code duplication in core helper
 functions (was: Re: [linux-pm] [PATCH] PM: add synchronous ...)

On Sat, 2 Oct 2010, Rafael J. Wysocki wrote:

> > > > BTW, I like some changes made by your patch that aren't really related to
> > > > the issue at hand, so I think the patch below can be applied regardless of
> > > > the other changes, unless I made a mistake I can see now.
> > > 
> > > It looks like a good change, but you forgot to preserve the assignments 
> > > to dev->power.runtime_error.
> > 
> > That's correct and there's a difference betwee _idle and the other cases
> > because of that.  I'll send updated patch with a changelog shortly.
> 
> Appended as promised.

This looks okay.  In principle you could tell rpm_callback whether or 
not to store the return value in dev->power.runtime_error (by passing 
an extra argument), but it's probably not worthwhile.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/