linux-kernel - Re: [PATCH] spi-gpio: SPI_MASTER_NO_RX bit tested twice, missing SPI_MASTER_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101003030241.GA28565@angua.secretlab.ca>
Date:	Sat, 2 Oct 2010 21:02:41 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	spi-devel-general@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi-gpio: SPI_MASTER_NO_RX bit tested twice, missing
 SPI_MASTER_NO_TX?

On Sat, Oct 02, 2010 at 02:03:32PM +0200, Roel Kluin wrote:
> The SPI_MASTER_NO_TX bit (can't do buffer write) wasn't tested.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  drivers/spi/spi_gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Is this what was intended?
> 

Obviously correct.  Merged

g.

> diff --git a/drivers/spi/spi_gpio.c b/drivers/spi/spi_gpio.c
> index e24a634..63e51b0 100644
> --- a/drivers/spi/spi_gpio.c
> +++ b/drivers/spi/spi_gpio.c
> @@ -350,7 +350,7 @@ static int __init spi_gpio_probe(struct platform_device *pdev)
>  	spi_gpio->bitbang.master = spi_master_get(master);
>  	spi_gpio->bitbang.chipselect = spi_gpio_chipselect;
>  
> -	if ((master_flags & (SPI_MASTER_NO_RX | SPI_MASTER_NO_RX)) == 0) {
> +	if ((master_flags & (SPI_MASTER_NO_TX | SPI_MASTER_NO_RX)) == 0) {
>  		spi_gpio->bitbang.txrx_word[SPI_MODE_0] = spi_gpio_txrx_word_mode0;
>  		spi_gpio->bitbang.txrx_word[SPI_MODE_1] = spi_gpio_txrx_word_mode1;
>  		spi_gpio->bitbang.txrx_word[SPI_MODE_2] = spi_gpio_txrx_word_mode2;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/