lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CA87A47.6030007@bfs.de>
Date:	Sun, 03 Oct 2010 14:42:47 +0200
From:	walter harms <wharms@....de>
To:	Tracey Dent <tdent48227@...il.com>
CC:	greg@...ah.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, sam@...nborg.org
Subject: Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile
 cflag lines



Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@...il.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
> index 7133894..1120c04 100644
> --- a/drivers/staging/rtl8192su/Makefile
> +++ b/drivers/staging/rtl8192su/Makefile
> @@ -1,12 +1,12 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  


I still do not think that -O2 belongs here.
it should simply be removed.

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON
> +ccflags-y += -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON
>  
> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
> +#ccflags-y += -DMUTIPLE_BULK_OUT
>  
>  r8192s_usb-objs :=		\
>  	r8192U_wx.o		\
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ