linux-kernel - Re: [PATCH 3/6] staging/ft1000-usb: fix build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201010041549.21088.arnd@arndb.de>
Date:	Mon, 4 Oct 2010 15:49:20 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Belisko Marek <marek.belisko@...il.com>
Cc:	"Greg Kroah-Hartman" <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] staging/ft1000-usb: fix build warnings

On Monday 04 October 2010, Belisko Marek wrote:
> >                     if (qtype) {
> >                     }
> > @@ -756,6 +762,7 @@ static long ft1000_ChIoctl (struct file *File, unsigned int Command,
> >                                         if (tempword & FT1000_DB_DPRAM_TX) {
> >                                             DEBUG("FT1000:ft1000_ChIoctl:Doorbell not available\n");
> >                                             result = -ENOTTY;
> > +                                               kfree(dpram_data);
> is shift of kfree() needed or just a typo?
> >                                             break;
> >                                         }
> >                                     }

Indentation in this driver is largely broken (should be using tabs only, but
uses tabs and spaces). I didn't want to add to this, but I guess it doesn't
matter much either way.

You should probably split larger functions into multiple smaller ones where
sensible so you can do a proper reindentation of the whole driver.

> Anyway there is also compilation warning:
> In function ‘copy_from_user’,
>     inlined from ‘ft1000_ChIoctl’ at
> drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c:709:36:
> /home/open-nandra/kernels/linux-next/arch/x86/include/asm/uaccess_32.h:212:26:
> warning: call to ‘copy_from_user_overflow’ declared with attribute
> warning: copy_from_user() buffer size is not provably correct
> 

This warning is compiler dependent, so it didn't show up on my system.
Just make an extra patch for it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/