linux-kernel - Re: [PATCH] x86: Reenable the AMD IOMMU if it's mysteriously vanished over suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101004141345.GU9817@amd.com>
Date:	Mon, 4 Oct 2010 16:13:45 +0200
From:	"Roedel, Joerg" <Joerg.Roedel@....com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: Re: [PATCH] x86: Reenable the AMD IOMMU if it's mysteriously
 vanished over suspend

On Mon, Oct 04, 2010 at 09:55:52AM -0400, Matthew Garrett wrote:
> On Mon, Oct 04, 2010 at 03:43:39PM +0200, Roedel, Joerg wrote:
> > 
> > Why have you moved this out of the enable_iommus() loop?
> 
> enable_iommus() is called on init, whereas this should only be performed 
> on resume.

Ok, it shouldn't be problematic to do this always, but only on resume is
safer.  Can you rename iommu_apply_quirks to iommu_apply_resume_quirks
then?

> I'll send out an updated patch later today.

Great. Looking forward to it.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/