linux-kernel - Re: [PATCH 03/10] memcg: create extensible page stat update routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CAA104C.3000708@linux.vnet.ibm.com>
Date:	Mon, 04 Oct 2010 23:05:08 +0530
From:	Ciju Rajan K <ciju@...ux.vnet.ibm.com>
To:	Greg Thelen <gthelen@...gle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	containers@...ts.osdl.org, Andrea Righi <arighi@...eler.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Subject: Re: [PATCH 03/10] memcg: create extensible page stat update routines

Greg Thelen wrote:
> Ciju Rajan K <ciju@...ux.vnet.ibm.com> writes:
>
>   
>> Greg Thelen wrote:
>>     
>>> Replace usage of the mem_cgroup_update_file_mapped() memcg
>>> statistic update routine with two new routines:
>>> * mem_cgroup_inc_page_stat()
>>> * mem_cgroup_dec_page_stat()
>>>
>>> As before, only the file_mapped statistic is managed.  However,
>>> these more general interfaces allow for new statistics to be
>>> more easily added.  New statistics are added with memcg dirty
>>> page accounting.
>>>
>>>
>>>
>>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>>> index 512cb12..f4259f4 100644
>>> --- a/mm/memcontrol.c
>>> +++ b/mm/memcontrol.c
>>> @@ -1592,7 +1592,9 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
>>>   * possibility of race condition. If there is, we take a lock.
>>>   */
>>>
>>>   -static void mem_cgroup_update_file_stat(struct page *page, int idx, int
>>> val)
>>>   
>>>       
>> Not seeing this function in mmotm 28/09. So not able to apply this patch.
>> Am I missing anything?
>>     
>
> How are you getting mmotm?
>
> I see the mem_cgroup_update_file_stat() routine added in mmotm
> (stamp-2010-09-28-16-13) using patch file:
>   http://userweb.kernel.org/~akpm/mmotm/broken-out/memcg-generic-filestat-update-interface.patch
>   
Sorry for the noise Greg. It was a mistake at my end. Corrected now.
Thanks!
>   Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>   Date:   Tue Sep 28 21:48:19 2010 -0700
>   
>       This patch extracts the core logic from mem_cgroup_update_file_mapped() as
>       mem_cgroup_update_file_stat() and adds a wrapper.
>   
>       As a planned future update, memory cgroup has to count dirty pages to
>       implement dirty_ratio/limit.  And more, the number of dirty pages is
>       required to kick flusher thread to start writeback.  (Now, no kick.)
>   
>       This patch is preparation for it and makes other statistics implementation
>       clearer.  Just a clean up.
>   
>       Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>       Acked-by: Balbir Singh <balbir@...ux.vnet.ibm.com>
>       Reviewed-by: Greg Thelen <gthelen@...gle.com>
>       Cc: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
>       Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
> If you are using the zen mmotm repository,
> git://zen-kernel.org/kernel/mmotm.git, the commit id of
> memcg-generic-filestat-update-interface.patch is
> 616960dc0cb0172a5e5adc9e2b83e668e1255b50.
>
>   
>>> +void mem_cgroup_update_page_stat(struct page *page,
>>> +				 enum mem_cgroup_write_page_stat_item idx,
>>> +				 int val)
>>>  {
>>>  	struct mem_cgroup *mem;
>>>
>>>   
>>>       

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/