linux-kernel - Re: [patch] xfs: properly account for reclaimed inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101004071904.GH4681@dastard>
Date:	Mon, 4 Oct 2010 18:19:04 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Alex Elder <aelder@....com>
Cc:	Johannes Weiner <hannes@...xchg.org>, xfs@....sgi.com,
	John Hawley <warthog9@...nel.org>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [patch] xfs: properly account for reclaimed inodes

On Fri, Oct 01, 2010 at 12:17:23PM -0500, Alex Elder wrote:
> On Fri, 2010-10-01 at 09:43 +0200, Johannes Weiner wrote:
> > When marking an inode reclaimable, a per-AG counter is increased, the
> > inode is tagged reclaimable in its per-AG tree, and, when this is the
> > first reclaimable inode in the AG, the AG entry in the per-mount tree
> > is also tagged.
> > 
> > When an inode is finally reclaimed, however, it is only deleted from
> > the per-AG tree.  Neither the counter is decreased, nor is the parent
> > tree's AG entry untagged properly.
> > 
> > Since the tags in the per-mount tree are not cleared, the inode
> > shrinker iterates over all AGs that have had reclaimable inodes at one
> > point in time.
> > 
> > The counters on the other hand signal an increasing amount of slab
> > objects to reclaim.  Since "70e60ce xfs: convert inode shrinker to
> > per-filesystem context" this is not a real issue anymore because the
> > shrinker bails out after one iteration.
> > 
> > But the problem was observable on a machine running v2.6.34, where the
> > reclaimable work increased and each process going into direct reclaim
> > eventually got stuck on the xfs inode shrinking path, trying to scan
> > several million objects.
> > 
> > Fix this by properly unwinding the reclaimable-state tracking of an
> > inode when it is reclaimed.
> > 
> > Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> > Cc: stable@...nel.org
> 
> Yes, this looks right to me.  The state was correctly
> adjusted in xfs_iget_cache_hit() when a RECLAIMABLE
> inode is found in the cache, but it was not done when
> reclaim completes.
> 
> Reviewed-by: Alex Elder <aelder@....com>

Alex, can you push this to Linus ASAP? This needs to go back to
stable kernels as well..

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/