linux-kernel - Re: [PATCH] Added firmware load patch to crap directory. This patch loads firmware from btusb when device is plugged in.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1286265155.17473.25.camel@aeonflux>
Date:	Tue, 05 Oct 2010 09:52:35 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	"Luis R. Rodriguez" <mcgrof@...il.com>
Cc:	Bala Shanmugam <sbalashanmugam@...eros.com>,
	linux-wireless@...r.kernel.org, linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Added firmware load patch to crap directory. This
 patch loads firmware from btusb when device is plugged in.

Hi Luis,

> > Marcel feels that Atheros sflash based BT device
> > +doesn't follow bluetooth H:2 specification and HCI commands should be supported
> > +in firmware if it is detected as bluetooth device. Using HCI command, firmware
> > +should be loaded.
> > +
> > +In sfash based device we don't have enough memory to support HCI commands in firmware.
> > +So load firmware from btusb when the device comes up.
> > +
> 
> You should still ask the maintainer for an alternative, otherwise the
> device unusable. Did you submit the patch first in [PATCH] form? If
> not please submit the patch, all I saw as an RFC and no followup at
> all.

I think it is pretty clear how these devices should be designed when it
comes to firmware loading. Just having different USB PIDs for firmware
loading stage and fully functional Bluetooth device stage is not that
hard to do. Other companies have done this.

If you device claims Bluetooth USB class descriptors, then it should
behave like that and offer HCI protocol running on it.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/