[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20101005114621.d64561cb.sfr@canb.auug.org.au>
Date: Tue, 5 Oct 2010 11:46:21 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "N.P.S." <napohybelskurwysynom2010@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: mmotm 2010-09-28-16-13 uploaded
Hi,
On Mon, 4 Oct 2010 16:16:00 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Thu, 30 Sep 2010 21:39:26 +0200
> "N.P.S." <napohybelskurwysynom2010@...il.com> wrote:
>
> > Here is a patch that removes duplicate includes introduced in -next and
> > -mmotm
> >
> > --
> > Zimny Lech
> >
> > arch/arm/mach-omap2/board-rx51-peripherals.c | 1 -
> > arch/arm/mm/flush.c | 1 -
> > arch/xtensa/include/asm/coprocessor.h | 1 -
> > drivers/mmc/host/ushc.c | 1 -
> > drivers/staging/ath6kl/os/linux/include/ar6000_drv.h | 1 -
> > drivers/staging/batman-adv/soft-interface.c | 1 -
> > drivers/staging/bcm/headers.h | 1 -
> > drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ----
> > drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h | 1 -
> > drivers/staging/brcm80211/brcmfmac/wl_iw.c | 4 ----
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 1 -
> > drivers/staging/rtl8712/drv_types.h | 1 -
> > drivers/staging/rtl8712/osdep_service.h | 1 -
> > drivers/staging/westbridge/astoria/gadget/cyasgadget.h | 3 ---
> > sound/soc/fsl/mpc5200_dma.c | 1 -
> > 15 files changed, 23 deletions(-)
>
> Removal of duplicated includes is a somewhat dangerous thing. If
> someone else says "hey, there's a duplicated include" and then fixes
> it, and if this patch removes the other include then whoops, we broke
> the build. This has happened before.
>
> So I'd ask that you redo and resend this patch shortly after 2.6.36 is
> released please, so I can get it into mainline quickly thus minimising
> the opportunity for such breakage.
Or could it be broken up and sent to the appropriate maintainers?
--
Cheers,
Stephen Rothwell sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists