[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101005093206.GB2977@legolas.emea.dhcp.ti.com>
Date: Tue, 5 Oct 2010 12:32:06 +0300
From: Felipe Balbi <balbi@...com>
To: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@...ia.com>
Cc: "tony@...mide.com" <tony@...mide.com>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"khilman@...prootsystems.com" <khilman@...prootsystems.com>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"zmc@...ian.net" <zmc@...ian.net>,
"a.j.buxton@...il.com" <a.j.buxton@...il.com>
Subject: Re: [PATCH 1/1] omap: Ptr "isr_reg" tracked as NULL was
dereferenced
Hi,
On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
>+ if (!isr_reg) {
>+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
>+ bank->method);
>+ BUG();
>+ }
this could be simply:
BUG_ON(!isr_reg);
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists