linux-kernel - Re: [PATCH 1/2] bitops: make asm-generic/bitops/find.h more generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CAB1950.8060103@tilera.com>
Date:	Tue, 5 Oct 2010 08:25:52 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>
Subject: Re: [PATCH 1/2] bitops: make asm-generic/bitops/find.h more generic

 On 9/29/2010 5:08 AM, Akinobu Mita wrote:
> asm-generic/bitops/find.h has the extern declarations of find_next_bit()
> and find_next_zero_bit() and the macro definitions of find_first_bit()
> and find_first_zero_bit(). It is only usable by the architectures which
> enables CONFIG_GENERIC_FIND_NEXT_BIT and disables
> CONFIG_GENERIC_FIND_FIRST_BIT.
>
> x86 and tile enable both CONFIG_GENERIC_FIND_NEXT_BIT and
> CONFIG_GENERIC_FIND_FIRST_BIT. These architectures cannot include
> asm-generic/bitops/find.h in their asm/bitops.h. So ifdefed extern
> declarations of find_first_bit and find_first_zero_bit() are put in
> linux/bitops.h.
>
> This makes asm-generic/bitops/find.h usable by these architectures
> and use it. Also this change is needed for the forthcoming duplicated
> extern declarations cleanup.

This looks good, thanks.

Acked-by: Chris Metcalf <cmetcalf@...era.com>

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/