linux-kernel - Re: [BUG 2.6.36-rc6] list corruption in module_bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010051923140.2556@localhost6.localdomain6>
Date:	Tue, 5 Oct 2010 19:43:33 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Arnd Bergmann <arnd@...db.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Brandon Philips <brandon@...p.org>
Subject: Re: [BUG 2.6.36-rc6] list corruption in module_bug_finalize

On Tue, 5 Oct 2010, Linus Torvalds wrote:

> On Tue, Oct 5, 2010 at 9:40 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> > Hmm, with this patch the corruption triggers at every boot (5 of
> > 5). Without it it's just happening randomly (1 of 10)
> >
> > Digging further. Dammit, I fear my evil plan fires back now due to
> > some even more lazy person who doesn't use modules. :)
> 
> Sre you sure you used the second version? The first version missed the
> cleanup at module unload time, and would have caused the symptoms you
> see.

Crap, yes. Stupid me managed to pick the wrong one though I'm sure I
double checked.

> I just tried my own machine with modules (and list debugging), and it
> seemed fine. And it show now all happen under the module mutex, so I
> don't see how it would be timing-sensitive.
> 
> But hey, maybe I'm missing something really silly.

Nah. Works fine. Sorry for making you build modules :)

Tested-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/