linux-kernel - Re: [PATCH] usb: gadget: langwell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CAB79C4.3030208@ru.mvista.com>
Date:	Tue, 05 Oct 2010 23:17:24 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Rahul Ruikar <rahul.ruikar@...il.com>
CC:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Joe Perches <joe@...ches.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: langwell_udc: Fix error path

Hello.

Rahul Ruikar wrote:

> Fix for following cases
> - Call device_unregister() only when device_register() is success.

    s/is success/succeeds/

> - Call put_device() when device_register() fails.
> - Call device_remove_file() only when device_create_file() is success.

    s/is success/succeeds/

> Signed-off-by: Rahul Ruikar <rahul.ruikar@...il.com>

[...]

> diff --git a/drivers/usb/gadget/langwell_udc.h b/drivers/usb/gadget/langwell_udc.h
> index 9719934..b212a70 100644
> --- a/drivers/usb/gadget/langwell_udc.h
> +++ b/drivers/usb/gadget/langwell_udc.h
> @@ -199,7 +199,9 @@ struct langwell_udc {
>  				vbus_active:1,
>  				suspended:1,
>  				stopped:1,
> -				lpm:1;	/* LPM capability */
> +				lpm:1,	/* LPM capability */
> +				reg_status:1,
> +				file_create:1;

    I'd rather have called this 'file_created'.

>  
>  	/* pci state used to access those endpoints */
>  	struct pci_dev		*pdev;

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/