linux-kernel - Re: [V9fs-developer] [PATCH 2/3] fs/9p: Add missing iput in v9fs_vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CABB4BD.6050705@linux.vnet.ibm.com>
Date:	Tue, 05 Oct 2010 16:29:01 -0700
From:	"Venkateswararao Jujjuri (JV)" <jvrao@...ux.vnet.ibm.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	v9fs-developer@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V9fs-developer] [PATCH 2/3] fs/9p: Add missing iput in v9fs_vfs_lookup

On 10/5/2010 10:01 AM, Aneesh Kumar K.V wrote:
> Make sure we drop inode reference in the error path
>
> Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@...ux.vnet.ibm.com>

Looks good to me.

Reviewed-by : Venkateswararao Jujjuri <jvrao@...ux.vnet.ibm.com>

> ---
>   fs/9p/vfs_inode.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 1ec9075..1ac9229 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -1028,7 +1028,7 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
>
>   	result = v9fs_fid_add(dentry, fid);
>   	if (result<  0)
> -		goto error;
> +		goto error_iput;
>
>   inst_out:
>   	if (v9ses->cache)
> @@ -1039,6 +1039,8 @@ inst_out:
>   	d_add(dentry, inode);
>   	return NULL;
>
> +error_iput:
> +	iput(inode);
>   error:
>   	p9_client_clunk(fid);
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/