linux-kernel - Re: [PATCH] x86, cpu: Fix X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101005061939.GB29161@liondog.tnic>
Date:	Tue, 5 Oct 2010 08:19:40 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, cpu: Fix X86_FEATURE_NOPL

From: "H. Peter Anvin" <hpa@...or.com>
Date: Mon, Oct 04, 2010 at 02:53:15PM -0700

> On 10/04/2010 02:48 PM, Borislav Petkov wrote:
> > 
> > I think the cleanup should be easy: on 64-bit unconditionally return
> > p6_nops in find_nop_table() since every 64-bit processor should support
> > them and on 32-bit never return p6_nops since X86_FEATURE_NOPL is not
> > set there and fall back to intel_nops on non-AMD. Which means we can get
> > rid of X86_FEATURE_NOPL altogether. Too radical?
> > 
> 
> FWIW, if P6_NOPs work as well as 66...90 on AMD,

Yeah, let me get back to you on that :).

>  I'd much rather switch to the fixed sequence for all 64-bit
> processors.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/